Update typings to explicitly not require a bound this
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user attempts to destructure the defer object, it can get flagged by @typescript-eslint/unbound-method.
The actual implementation does not at all require a reference to this (
resolve
+reject
is the native value provided in the promise callback), but the typescript definitions do not make it clear, and since it is being pulled off a object, eslint thinks it might need a reference tothis
.Example:
(This example is an oversimplification, and not a great place to legitimately use this library, but enough to recreate the issue)
The solution is to just update the typing to explicitly declare the
this
as ignorable (void
).